[v3 04/12] comctl32: Extend TaskDialog, add simple callback and tests

[Fabian Maurer]

> On 11.03.2017 1:14, Fabian Maurer wrote:
> >> There's no reason to introduce global variable for that, just to remove
> >> it two patches after.
> > 
> > It's not split the functionality into two patches. I could merge them if
> > you want, but I thought it would be easier to understand if I separated
> > those two logical changes. First getting it to work with a global
> > variable, then change it into something thread-safe.
> 
> Yes, I think it's better to do it in a clean way from the start, it
> doesn't add additional complexity anyway, only SetProp/GetProp.
I understand. I just thought it would be useful that way, but I'll change it.

> >> For minimal working replacement of MessageBox callback support is not
> >> needed, right?
> > 
> > No it's not needed. But, we certainly want the tests, don't we? Without
> > callback, there'll be no tests.
> 
> We can have tests that have todo_wine's all over, until callbacks are
> supported, it's not a problem.
Well if we're going that route, why not leave the tests out alltogether and 
add then once the callbacks are implemented? There isn't a real benefit to add 
them now if they can't test wine yet.

Regards,
Fabian Maurer