[PATCH 4/5] server: Added server side mamed pipe read and write implementation and use it for message mode pipes.

[Alexandre Julliard]

Sebastian Lackner <sebastian at fds-team.de> writes:

> Thanks for sharing the draft patch. All of the ideas you mentioned
> sound reasonable, but if you already know how to solve these problems,
> I am not sure why you insist on merging your named pipe implementation
> first. The goal should be to keep the risk of regressions (this also
> includes performance regressions - or weird issues because USR1
> signals arrive on other threads, possibly interrupting libraries
> which cannot deal with it) as small as possible. Imho it would be
> preferred to fix the limitations first, then adding the named pipe
> implementation.
>
> So far I'm also not sure yet if this separate async_complete
> wineserver call really is the best approach. What about just using the
> existing wait mechanism? Either read/write immediately starts a wait
> and the ntdll side would look similar to server_select().
> Alternatively it would also be sufficient to block USR1 signals until
> ntdll has reached NtWaitForSingleObject. If you decide to add such a
> flag, it could probably also be reused to fix another bug.
>
> [@ Alexandre: Do you think those concerns are valid, or do you think
> the patches would be acceptable despite the problems?]

I think we can do it either way. I'm not necessarily opposed to merging
the named pipe support first and improving the APC mechanism afterwards.
I would like to see smaller patches though...

-- 
Alexandre Julliard
julliard at winehq.org