shell32/tests: Return early if the shell folder creation fails in order to avoid a compiler warning.

Huw Davies huw at codeweavers.com
Fri Mar 17 06:38:16 CDT 2017


On Fri, Mar 17, 2017 at 05:54:18AM -0500, Marvin wrote:
> Hi,
> 
> While running your changed tests on Windows, I think I found new failures.
> Being a bot and all I'm not very good at pattern recognition, so I might be
> wrong, but could you please double-check?
> Full results can be found at
> https://testbot.winehq.org/JobDetails.pl?Key=29562
> 
> Your paranoid android.
> 
> 
> === wvistau64 (32 bit shlfolder) ===
> shlfolder.c:457: Test failed: 0: got 7480017f expected 7080017f
> shlfolder.c:457: Test failed: 1: got f480017f expected 7080017f
> shlfolder.c:457: Test failed: 2: got 44400177 expected 40400177
> shlfolder.c:457: Test failed: 3: got 44400177 expected 40400177
> shlfolder.c:457: Test failed: 4: got 44400177 expected 40400177
> 
> === wvistau64 (64 bit shlfolder) ===
> shlfolder.c:457: Test failed: 0: got 7480017f expected 7080017f
> shlfolder.c:457: Test failed: 1: got f480017f expected 7080017f
> shlfolder.c:457: Test failed: 2: got 44400177 expected 40400177
> shlfolder.c:457: Test failed: 3: got 44400177 expected 40400177
> shlfolder.c:457: Test failed: 4: got 44400177 expected 40400177
>

This is odd since they're run before my changes, and my changes
are essentially a nop.

I submitted a job that really was a nop and we get the same
failures:

https://testbot.winehq.org/JobDetails.pl?Key=29566

Huw.



More information about the wine-devel mailing list