[PATCH 2/5] usp10: Avoid LPPOINT.

Henri Verbeet hverbeet at gmail.com
Wed Mar 22 11:05:43 CDT 2017


On 22 March 2017 at 16:45, Aric Stewart <aric at codeweavers.com> wrote:
> I think I would personally almost prefer if all 4 of these where one patch. A few of them are only 1-2 changes and this one does both avoid LPPOINT and avoid LPCVOID, some of them rename variables as well. All changes I am happy to sign-off on.
>
I can do that if you think that makes it easier to review, but note
that I have 3 more patches for this kind of cleanup. Generally
speaking I think we prefer to err on the side of splitting things up.

For what it's worth, the rule I've been using is to treat changing a
line the same as writing new code. I.e., if there are other issues in
the same line, fixing those as well, unless there's a reason not to,
like changing behaviour or requiring changes in a lot of other lines
as well.



More information about the wine-devel mailing list