[PATCH 4/5] include: Add comments to blocks of render states added with each D3D version.
Matteo Bruni
matteo.mystral at gmail.com
Thu Mar 23 17:55:18 CDT 2017
2017-03-23 14:19 GMT+01:00 Henri Verbeet <hverbeet at gmail.com>:
> On 22 March 2017 at 23:17, Matteo Bruni <mbruni at codeweavers.com> wrote:
>> Signed-off-by: Matteo Bruni <mbruni at codeweavers.com>
>> ---
>> include/wine/wined3d.h | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
> Are you using these? I'm not necessarily opposed, but in principle
> wined3d has no concept of Direct3D versions. There's also the
> consideration that in principle render states will eventually go away
> in favour of DIrect3D 10 style state object.
They have been somewhat useful for me a number of times, mostly when
writing tests. I agree that wined3d.h probably isn't the most
appropriate place though.
I could move the comments to d3d[89]types.h. The other option is to
just get rid of them.
More information about the wine-devel
mailing list