[PATCH 4/9] xmllite: Return static namespace instances for default namespaces in reader_lookup_ns.

Nikolay Sivov bunglehead at gmail.com
Tue Mar 28 09:54:46 CDT 2017


On 28.03.2017 17:44, Jacek Caban wrote:
> Signed-off-by: Jacek Caban <jacek at codeweavers.com>
> ---
>  dlls/xmllite/reader.c | 33 +++++++++++++++++++++++++++------
>  1 file changed, 27 insertions(+), 6 deletions(-)
> 


> 
> +static struct ns default_ns = {
> +    { emptyW },
> +    { emptyW }
>  };
>  

I think this could use a better name. Default namespace is something
defined with unprefixed "xmlns" attribute name. Maybe empty_ns? To match
empty strings naming.

Also everything static in this patch should be also const, no?



More information about the wine-devel mailing list