[PATCH 2/3] include/wmsdkidl.idl: Add more interfaces

[Austin English]

On May 10, 2017 00:36, "Alex Henrie" <alexhenrie24 at gmail.com> wrote:

2017-05-09 23:25 GMT-06:00 Dmitry Timoshkov <dmitry at baikal.ru>:
> Alex Henrie <alexhenrie24 at gmail.com> wrote:
>
>> +    HRESULT GetBandwidth(   [out] DWORD *bitrate,
>> +                            [out] DWORD *buffer );
>> +
>> +    HRESULT SetBandwidth(   [in] DWORD bitrate,
>> +                            [in] DWORD buffer );
>>
>> The extra spaces after the left parentheses look like a mistake; they
>> don't match the format in the rest of the file.
>
> Because everything was directly copy-pasted from appropriate PSDK headers.

Even if the original files are ugly, ours don't have to be. I'm not
going to sign off on copy-pasted headers.

-Alex


Fyi, copy/pasted headers aren't acceptable in Wine, regardless of
maintainer sign off.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20170510/33dd200a/attachment-0001.html>