[PATCH 7/7] wined3d: Add support for patch constant signatures.

Henri Verbeet hverbeet at gmail.com
Thu May 11 05:02:21 CDT 2017


On 10 May 2017 at 15:54, Józef Kucia <jkucia at codeweavers.com> wrote:
> +    if (FAILED(hr = shader_signature_calculate_strings_length(&desc->input_signature, &len)))
> +        return hr;
> +    total = len;
> +    if (FAILED(hr = shader_signature_calculate_strings_length(&desc->output_signature, &len)))
> +        return hr;
> +    total += len;
> +    if (FAILED(hr = shader_signature_calculate_strings_length(&desc->patch_constant_signature, &len)))
> +        return hr;
> +    total += len;
It's perhaps a fairly theoretical concern, but I think you can still
make "total" overflow here.



More information about the wine-devel mailing list