rpcrt4: Use standard Wine list to store connections in RpcServerProtseq.

Jacek Caban jacek at codeweavers.com
Mon May 15 14:27:33 CDT 2017


On 15.05.2017 20:50, Alexandre Julliard wrote:
> Jacek Caban <jacek at codeweavers.com> writes:
>
>> Signed-off-by: Jacek Caban <jacek at codeweavers.com>
>> ---
>>  dlls/rpcrt4/rpc_binding.h   |   2 +-
>>  dlls/rpcrt4/rpc_server.c    |  18 ++++----
>>  dlls/rpcrt4/rpc_server.h    |   2 +-
>>  dlls/rpcrt4/rpc_transport.c | 110
>> +++++++++++++++-----------------------------
>>  4 files changed, 50 insertions(+), 82 deletions(-)
> This breaks the Windows build:

Sorry about that, I will send a fixed version. However, this rises my
other related concern. What do you think about changing this code to
always use winsock? We'd use single implementation, making the code
cleaner and avoiding breaking other configs. I guess the original
reasoning was combination of performance and less mature winsock
implementation at the time. I don't think winsock overhead would be too
bad in this case and ws2_32 should be up to the task.

I'm working on more changes to this area, so if we're going to switch to
winsock, it would make sense to start with it.

Thanks,
Jacek



More information about the wine-devel mailing list