[PATCH] authz: document missorted function in specfile

Austin English austinenglish at gmail.com
Wed May 24 02:10:31 CDT 2017


On Wed, May 24, 2017 at 2:01 AM, Nikolay Sivov <bunglehead at gmail.com> wrote:
> On 24.05.2017 9:50, Austin English wrote:
>> The comment helps future readers understand why the sorting rules
>> apply one way in one place, but the complete opposite in another. It's
>> completely non-obvious which sorting mistakes are developer error, and
>> which are Microsoft error and IMO should be documented. Keep in mind
>> that not every developer has access to a windows machine (Testbot
>> excluded), and may not be easily able to run winedump on some windows
>> dlls.
>
> For modules with "unexpected" order you can have a comment on top of
> spec file, mentioning that this file is sorted as it should be. That is
> if you want comment at all, comments in the middle look like noise to me.

That works for me. There are a few modules that I'd like to strip
comments from, actually...

-- 
-Austin
GPG: 14FB D7EA A041 937B



More information about the wine-devel mailing list