[PATCH] comctl32/listview: Do not select the first list item when drawing a marquee rectangle

Hugh McMaster hugh.mcmaster at outlook.com
Mon May 29 04:14:23 CDT 2017


On Wednesday, 24 May 2017 4:34 AM, Nikolay Sivov wrote:
> I see what you mean, when you start selecting with marquee first item in
> report mode is always selected. This patch fixes that, but breaks ICON
> mode it seems - sometimes items are not selected when they are clearly
> intersect with marquee rectangle. 

Sorry for the delayed reply. Yes, I see what you mean by ICON mode.

> Admittedly this selection mode is
> already funny in ICON mode, it does not use dead zones properly, so
> slight movement selects things, while it should check with icon
> rectangle when resized horizontally, and allow about half icon rectangle
> intersect marquee vertically before setting item state.

Personally, I don't see any noticeable difference in ICON mode selection behaviour
when the patch is applied. But one thing is certain - the selection behaviour for that mode
is largely broken.


More information about the wine-devel mailing list