[v3] oleaut32: Add ARM support to DispCallFunc().

Alexandre Julliard julliard at winehq.org
Wed Nov 1 17:21:16 CDT 2017


Donna Whisnant <dewhisna at dewtronics.com> writes:

> Ah...  I hadn't tried it on a platform with soft-FP.  And true enough,
> the compiler wouldn't support the VFP coprocessor instructions without
> hardware floats.  It could be made to work with soft-FP too, but would
> at least be a different function for the assembly language part to one
> that excludes the VFP coprocessor instructions.
>
> I think the correct answer for now would be to do the
> !defined(__SOFTFP__) in my code, just as described in the discussion at
> the link you sent.  It seems correct since this code is explicitly
> written for hard-FP.

I've fixed my Android toolchain and added a configure check to require
floating point support, so hopefully this will work now.

> However, the stdcall tests have absolutely nothing to do with whether or
> not it's win64, but rather if the ABI itself supports stdcall or not. 
> In my opinion, I believe there should be a constant defined at the top
> according to the ABI.  I *think* the only platform that supports stdcall
> like that is i386, so have something like:
>
> #ifdef (__i386__)
> static const BOOL abi_supports_stdcall = TRUE;
> #else
> static const BOOL abi_supports_stdcall = FALSE;
> #endif
>
> And then change the 'if' using it to be:
>     if (abi_supports_stdcall)
>     {
>     ...
>     }
>
> I hadn't submitted that patch yet, since I didn't know how you wanted to
> address it.  But, if that's an acceptable solution, I would be glad to
> make a patch for the test suite too.

Sure, that would be fine.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list