[PATCH 3/4] oleaut32: Implement asm proxys for x86_64.

Alexandre Julliard julliard at winehq.org
Tue Nov 7 01:40:34 CST 2017


Marcus Meissner <marcus at jet.franken.de> writes:

> On Mon, Nov 06, 2017 at 07:36:26PM +0100, Alexandre Julliard wrote:
>> Marcus Meissner <marcus at jet.franken.de> writes:
>> 
>> > From: Sebastian Lackner <sebastian at fds-team.de>
>> >
>> > Signed-off-by: Sebastian Lackner <sebastian at fds-team.de>
>> > Signed-off-by: Marcus Meissner <marcus at jet.franken.de>
>> > ---
>> >  dlls/oleaut32/tmarshal.c | 54 ++++++++++++++++++++++++++++++++++++++++++++++--
>> >  1 file changed, 52 insertions(+), 2 deletions(-)
>> 
>> The existing code is ugly, and instead of trying to retrofit 64-bit
>> support into it, I'd suggest looking into reusing the rpcrt4 routines
>> which already handle pretty much all of this in a more correct way.
>
> I will try to take a look, but I do not see the approach to take yet.
> We would need to map typelib trees to midl codes/ ndr call trees to be
> able to handle this?

Yes, you'd want to generate format strings for the typelib.

If that's not feasible for some reason, we can look into sharing the
implementation; but obviously making use of exported APIs is preferable.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list