[PATCH] d3dx9/tests: Provide 8 significant digits in matrix reference values

Henri Verbeet hverbeet at gmail.com
Thu Nov 9 02:52:19 CST 2017


Thanks for fixing these.

2017-11-09 6:10 GMT+01:00 Alex Henrie <alexhenrie24 at gmail.com>:
> Signed-off-by: Alex Henrie <alexhenrie24 at gmail.com>
> ---
> Fixes test failures on 64-bit Linux.
>
> A 32-bit float can hold 7.2 decimal digits, so it's best to provide 8 to
> make sure that the correct values are accurately represented.
>
If it were up to me, I'd prefer these to be in the same %.8e format
the failure messages use.

> The correct outputs of functions that take simple floats as inputs were
> computed by feeding equations into Wolfram Alpha.
I think that's probably fine, but note that we don't care about the
"correct" values so much as "whatever Windows produces". Hopefully
those would be reasonably close, but they're by no means guaranteed to
be the same.



More information about the wine-devel mailing list