[PATCH] d3dx10: Add D3DX10PreprocessShaderFromMemory stub.

Matteo Bruni matteo.mystral at gmail.com
Thu Nov 9 17:48:51 CST 2017


2017-11-10 0:40 GMT+01:00 Henri Verbeet <hverbeet at gmail.com>:
> On 9 November 2017 at 17:55, Andrey Gusev <andrey.goosev at gmail.com> wrote:
>> +HRESULT WINAPI D3DX10PreprocessShaderFromMemory(const char *data, SIZE_T data_size, const char *filename,
>> +        const D3D10_SHADER_MACRO *defines, ID3DInclude *include, ID3DX10ThreadPump *pump, ID3D10Blob **shader_text,
>> +        ID3D10Blob **errors, HRESULT *hresult)
>> +{
>> +    FIXME("data %s, data_size %lu, filename %s, defines %p, include %p, pump %p, shader_text %p, errors %p, "
>> +            "hresult %p stub!\n",
>> +            debugstr_a(data), data_size, debugstr_a(filename), defines, include, pump, shader_text, errors, hresult);
> It's questionable how useful debugstr_a() is for "data", but it's also
> wrong. "data" is not necessarily \0 terminated, "data_size" specifies
> its length.

Oh, good point. I even changed that in some other function...

>> -@ stub D3DX10PreprocessShaderFromMemory(str long str ptr ptr ptr ptr ptr)
>> +@ stdcall D3DX10PreprocessShaderFromMemory(str long str ptr ptr ptr ptr ptr ptr)
> Likewise.

Yep.



More information about the wine-devel mailing list