[PATCH] d3dx9/tests: Use a macro to initialize matrix rows in math tests

Henri Verbeet hverbeet at gmail.com
Fri Nov 10 06:40:52 CST 2017


On 10 November 2017 at 15:58, Alex Henrie <alexhenrie24 at gmail.com> wrote:
> 2017-11-10 1:57 GMT-07:00 Henri Verbeet <hverbeet at gmail.com>:
>> On 10 November 2017 at 08:06, Alex Henrie <alexhenrie24 at gmail.com> wrote:
>>> +#define SET_ARRAY4(array, a, b, c, d) array[0] = a; array[1] = b; array[2] = c; array[3] = d
>> You don't need a macro for that.
>
> Are you saying that each expected matrix should be a static const variable?
>
Well, if you can make it work, a tests[] array would probably be
preferable. But wrt. SET_ARRAY specifically, there's no reason that
couldn't be a function.



More information about the wine-devel mailing list