[PATCH 5/9] wined3d: Allow copies between compatible formats in wined3d_device_copy_sub_resource_region().
Henri Verbeet
hverbeet at codeweavers.com
Wed Nov 15 15:13:04 CST 2017
From: Józef Kucia <jkucia at codeweavers.com>
Signed-off-by: Henri Verbeet <hverbeet at codeweavers.com>
---
dlls/d3d9/device.c | 13 +++++++++++++
dlls/wined3d/device.c | 5 +++--
2 files changed, 16 insertions(+), 2 deletions(-)
diff --git a/dlls/d3d9/device.c b/dlls/d3d9/device.c
index 50bba6b..3b0b483 100644
--- a/dlls/d3d9/device.c
+++ b/dlls/d3d9/device.c
@@ -1393,6 +1393,7 @@ static HRESULT WINAPI d3d9_device_UpdateSurface(IDirect3DDevice9Ex *iface,
struct d3d9_device *device = impl_from_IDirect3DDevice9Ex(iface);
struct d3d9_surface *src = unsafe_impl_from_IDirect3DSurface9(src_surface);
struct d3d9_surface *dst = unsafe_impl_from_IDirect3DSurface9(dst_surface);
+ struct wined3d_sub_resource_desc src_desc, dst_desc;
struct wined3d_box src_box;
HRESULT hr;
@@ -1403,6 +1404,18 @@ static HRESULT WINAPI d3d9_device_UpdateSurface(IDirect3DDevice9Ex *iface,
wined3d_box_set(&src_box, src_rect->left, src_rect->top, src_rect->right, src_rect->bottom, 0, 1);
wined3d_mutex_lock();
+
+ wined3d_texture_get_sub_resource_desc(src->wined3d_texture, src->sub_resource_idx, &src_desc);
+ wined3d_texture_get_sub_resource_desc(dst->wined3d_texture, dst->sub_resource_idx, &dst_desc);
+ if (src_desc.format != dst_desc.format)
+ {
+ wined3d_mutex_unlock();
+ WARN("Surface formats (%#x/%#x) don't match.\n",
+ d3dformat_from_wined3dformat(src_desc.format),
+ d3dformat_from_wined3dformat(dst_desc.format));
+ return D3DERR_INVALIDCALL;
+ }
+
hr = wined3d_device_copy_sub_resource_region(device->wined3d_device,
wined3d_texture_get_resource(dst->wined3d_texture), dst->sub_resource_idx, dst_point ? dst_point->x : 0,
dst_point ? dst_point->y : 0, 0, wined3d_texture_get_resource(src->wined3d_texture),
diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c
index 1995a50..9fbf3b0 100644
--- a/dlls/wined3d/device.c
+++ b/dlls/wined3d/device.c
@@ -4100,9 +4100,10 @@ HRESULT CDECL wined3d_device_copy_sub_resource_region(struct wined3d_device *dev
return WINED3DERR_INVALIDCALL;
}
- if (src_resource->format->id != dst_resource->format->id)
+ if (src_resource->format->typeless_id != dst_resource->format->typeless_id
+ || (!src_resource->format->typeless_id && src_resource->format->id != dst_resource->format->id))
{
- WARN("Resource formats (%s / %s) don't match.\n",
+ WARN("Resource formats %s and %s are incompatible.\n",
debug_d3dformat(dst_resource->format->id),
debug_d3dformat(src_resource->format->id));
return WINED3DERR_INVALIDCALL;
--
2.1.4
More information about the wine-devel
mailing list