[PATCH] comctl32/tests: Fix propsheet template buffer size test on RTL locales

[Alexandre Julliard]

Alex Henrie <alexhenrie24 at gmail.com> writes:

> 2017-11-15 11:46 GMT-07:00 Alexandre Julliard <julliard at winehq.org>:
>> Alex Henrie <alexhenrie24 at gmail.com> writes:
>>
>>> I used Hebrew Windows for testing because it's simpler than Arabic:
>>> Windows only recognizes one Hebrew dialect.
>>>
>>> English: Resource size 254, buffer size 508
>>> Arabic: Resource size 270, buffer size 508
>>> Hebrew: Resource size 250, buffer size 508
>>> German: Resource size 266, buffer size 532
>>
>> Is it actually using the Hebrew resource though? Maybe it needs the
>> propsheet pages to be RTL or something like that.
>
> Interesting, I think you're right: If I call
> SetProcessDefaultLayout(LAYOUT_RTL) at the beginning of the tests then
> the buffer size tests pass. This suggests three possible solutions:
>
> 1. Call SetProcessDefaultLayout(LAYOUT_RTL) before any of the tests
> run, and change test_buttons to expect the buttons to be in reverse
> order if on an RTL locale.

This one is probably the best, it's the one nearest to normal
application usage.

-- 
Alexandre Julliard
julliard at winehq.org