[PATCH] gdiplus/tests: Don't ignore successful tests.
Alexandre Julliard
julliard at winehq.org
Tue Nov 21 03:01:21 CST 2017
Zebediah Figura <z.figura12 at gmail.com> writes:
> On 11/20/2017 01:21 PM, Vincent Povirk wrote:
>>> {
>>> UINT i, size = sizeof(dst_8x1);
>>> const BYTE *bits = dst_8x1;
>>> for (i = 0; i < size; i++)
>>> - trace(" %02x", bits[i]);
>>> - trace("\n");
>>> + printf(" %02x", bits[i]);
>>> + printf("\n");
>>> }
>>> }
>>
>> Did you mean to include this part?
>>
>
> Yes, to avoid the trace() prefix being printed before every number. I
> can submit this in a separate patch if that would be preferable.
The problem is that this prints the data even in silent mode, and when
there's no reported failure (because of the todo_wine). Printing into a
buffer and then trace()ing it would be better.
--
Alexandre Julliard
julliard at winehq.org
More information about the wine-devel
mailing list