[PATCH 1/1] rasapi32: Add stub for RasGetConnectionStatistics

[Станислав Мотыльков]

Indeed, that change in header file was done by Sebastian Lackner, he
accepted my patch in Wine Staging:
https://dev.wine-staging.com/patches/203/

Attached my updated patch.

Also can you advice whether this is ok to send patch that already was
submitted to Wine Staging, should I wait for it or it is normal to go
forward?

Regards,
Stas'M.

On 11/22/17, Alex Henrie <alexhenrie24 at gmail.com> wrote:
> 2017-11-22 6:33 GMT-07:00 Станислав Мотыльков <x86corez at gmail.com>:
>> This patch allows to run some programs that require this API --
>> without it they can't start. Don't know whether there are existing
>> bug-reports in Wine referring this, but there's open bug report in
>> ReactOS project tracker:
>> https://jira.reactos.org/browse/CORE-10426
>
> OK. There are still two more problems. First, the patch does not compile:
>
> rasapi.c: In function ‘RasGetConnectionStatistics’:
> rasapi.c:554:12: error: ‘ERROR_UNKNOWN’ undeclared (first use in this
> function); did you mean ‘DRIVE_UNKNOWN’?
>      return ERROR_UNKNOWN;
>             ^~~~~~~~~~~~~
>             DRIVE_UNKNOWN
>
> It looks like you forgot to include the change to raserror.h that was
> included in your Wine Staging patch:
> https://github.com/wine-compholio/wine-staging/blob/master/patches/rasapi32-RasGetConnectionStatistics/0001-rasapi32-Add-stub-for-RasGetConnectionStatistics.patch
>
> Second, you need to include a Signed-off-by line in your commit
> message. See https://wiki.winehq.org/Submitting_Patches#The_commit_message
>
> -Alex
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-rasapi32-Add-stub-for-RasGetConnectionStatistics.patch
Type: application/octet-stream
Size: 2014 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20171122/5c53795c/attachment-0001.obj>