[PATCH 1/1] rasapi32: Add stub for RasGetConnectionStatistics

Станислав Мотыльков x86corez at gmail.com
Wed Nov 22 13:47:08 CST 2017


> I'm not sure it matters, but I think it should go between
RasGetConnectStatusWow and RasGetCountryInfoA.

Yeah, looks like the functions are sorted alphabetically, let it be
so, I updated my patch again.

Thanks!

Regards,
Stas'M.

On 11/22/17, Alex Henrie <alexhenrie24 at gmail.com> wrote:
> 2017-11-22 11:19 GMT-07:00 Станислав Мотыльков <x86corez at gmail.com>:
>> Indeed, that change in header file was done by Sebastian Lackner, he
>> accepted my patch in Wine Staging:
>> https://dev.wine-staging.com/patches/203/
>>
>> Attached my updated patch.
>
> Great! By the way, I noticed that you put RasGetConnectionStatistics
> between RasGetAutodialParamW and RasGetConnectResponse in the
> specfile. I'm not sure it matters, but I think it should go between
> RasGetConnectStatusWow and RasGetCountryInfoA.
>
>> Also can you advice whether this is ok to send patch that already was
>> submitted to Wine Staging, should I wait for it or it is normal to go
>> forward?
>
> Patches are not automatically pulled into Wine from Wine Staging. It's
> best to submit the patch to Wine yourself as you just did.
>
> -Alex
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rasapi32.patch
Type: application/octet-stream
Size: 1966 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20171122/08b2f211/attachment-0001.obj>


More information about the wine-devel mailing list