[PATCH v6 1/2] gdi32: In AddFaceToList allow fonts with long names and add tests

Fabian Maurer dark.shadow4 at web.de
Mon Nov 27 16:02:15 CST 2017


On Montag, 27. November 2017 12:00:10 CET Huw Davies wrote:
> How about truncating FamilyName to LF_FACESIZE-1 and FuillName to
> LF_FULLFACESIZE-1.  Then most comparisons would be strcmpiW(), except
> the two where we compare FullName with something that came from an
> lfFaceName?

Possibly, but my last tests made me question whether it's good to truncate the 
strings at all. I'm not sure if we need them later, so why not just compare them 
correctly.

E.g. in 
> strcpyW(elf.elfFullName, family->FamilyName);
I think we need the whole name.

Regards,
Fabian Maurer
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20171127/49742c58/attachment.html>


More information about the wine-devel mailing list