[v2 PATCH 1/2] advapi32: Handle WinLogonIdsSid in CreateWellKnownSid
Alexandre Julliard
julliard at winehq.org
Mon Oct 2 12:55:05 CDT 2017
Alistair Leslie-Hughes <leslie_alistair at hotmail.com> writes:
> @@ -967,7 +967,7 @@ CreateWellKnownSid( WELL_KNOWN_SID_TYPE WellKnownSidType,
> unsigned int i;
> TRACE("(%d, %s, %p, %p)\n", WellKnownSidType, debugstr_sid(DomainSid), pSid, cbSid);
>
> - if (cbSid == NULL || (DomainSid && !IsValidSid(DomainSid)))
> + if (cbSid == NULL || (DomainSid && !IsValidSid(DomainSid)) || WellKnownSidType == WinLogonIdsSid)
It doesn't look right to special-case it like this. It probably needs
more test cases to find out what's going on with such sids.
--
Alexandre Julliard
julliard at winehq.org
More information about the wine-devel
mailing list