[v2] msvcrt: Introduce vf[w]printf_helper function.

Piotr Caban piotr.caban at gmail.com
Fri Oct 6 12:41:59 CDT 2017


On 10/02/17 21:46, Gijs Vermeulen wrote:
> -int CDECL MSVCRT_vfprintf(MSVCRT_FILE* file, const char *format, __ms_va_list valist)
> +static int vfprintf_vfwprintf_helper(MSVCRT_FILE* file, const char *format, const MSVCRT_wchar_t *format_wide,
> +        __ms_va_list valist, MSVCRT__locale_t locale, DWORD options, BOOL wide)
I would prefer to have a separate helper for vfprintf and vfwprintf 
functions. Also please reorder the parameters so it's more similar to 

> +    if(!MSVCRT_CHECK_PMT( file != NULL )) return -1;
> +    if(!(wide && MSVCRT_CHECK_PMT( format != NULL ))) return -1;
This doesn't work as expected. It should look like this:
if(!wide && !MSVCRT_CHECK_PMT(...


More information about the wine-devel mailing list