[PATCH] d3dx9/tests: Avoid bitwise operation.
Matteo Bruni
matteo.mystral at gmail.com
Mon Oct 9 13:57:48 CDT 2017
2017-10-09 19:21 GMT+02:00 Fabian Maurer <dark.shadow4 at web.de>:
>> if (!end1 && !end2) break;
>>
>> - status = !end1 ^ !end2;
>> + status = !end1 && !end2;
>> ok(!status, "Line %u, test %u: Mismatch in size, test declaration
>> is %s than expected.\n", line, test_id, end1 ? "shorter" : "longer");
>> if (status)
>
> Doesn't this change the meaning of the code?
> You could also just make it into "status = FALSE", since when it's true the
> conditional break is used.
Yeah, that doesn't look right.
More information about the wine-devel
mailing list