[1/2] kerberos: Add a stub for Kerberos5 Authentication Package.
Alexandre Julliard
julliard at winehq.org
Tue Oct 17 10:45:28 CDT 2017
Hans Leidekker <hans at codeweavers.com> writes:
> On Tue, 2017-10-17 at 14:57 +0200, Jacek Caban wrote:
>> On 10/17/17 1:07 PM, Hans Leidekker wrote:
>> > Thanks. Alexandre pointed out that we do not need to load libkrb5
>> > dynamically because libgssapi_krb5 depends on libkrb5. So if libkrb5
>> > is missing the SSP wouldn't be usable anyway.
>>
>> I do not think that a not functioning stub (when dependencies are
>> missing) is useless. I added the stub because it was needed (and enough)
>> for Office 2013 installer. The installer needs to register
>> authentication info for its RPC server successfully. As long as no
>> actual authentication is done (and installer also registers NTLM info,
>> which is used in practice), a stub is enough.
>>
>> That said, if EnumerateSecurityPackagesW will not return kerberos
>> without libkrb5 available, libkrb5 will become a hard dependency of
>> Office 2013 installer (and Office 2016 I guess, but I didn't verify
>> that). It might be okay, but please take that into account in
>> considerations.
>
> Right, this is why I left the stubs in when building without Kerberos
> support. We could keep the stub provider in secur32 as a fallback, or
> build kerberos.dll in all cases but with stubs if support is missing.
If we have a kerberos.dll, I think it makes more sense to handle the
stubs there too.
--
Alexandre Julliard
julliard at winehq.org
More information about the wine-devel
mailing list