[PATCH 2/2] msi: Don't leak memory on failure.

Nikolay Sivov bunglehead at gmail.com
Sat Oct 21 05:16:30 CDT 2017


On 21.10.2017 12:50, Pierre Schweitzer wrote:
>          row = MSI_CreateRecord(1);
>          if (!row)
> +        {
> +            msi_free(buffer);
>              return NULL;
> +        }
>          MSI_RecordSetStringW(row, 1, buffer);
>          msi_free(buffer);
>          return row;

You can replace this with:

---
row = MSI_CreateRecord(1);
if (row)
    MSI_RecordSetStringW(row, 1, buffer);
msi_free(buffer);
return row;
---



More information about the wine-devel mailing list