[PATCH] ddraw/tests: Avoid dereferencing a null pointer in case of failure.
hverbeet at gmail.com
Mon Oct 23 09:47:19 CDT 2017
On 23 October 2017 at 16:20, Zebediah Figura <z.figura12 at gmail.com> wrote:
> On 10/23/2017 02:29 AM, Henri Verbeet wrote:
>> On 22 October 2017 at 00:32, Zebediah Figura <z.figura12 at gmail.com> wrote:
>>> This should fix a persistent crash on one of the XP test machines.
>>> Signed-off-by: Zebediah Figura <z.figura12 at gmail.com>
>> Why does it fail? It shouldn't. Does this run against Microsoft's
>> ddraw, or against some VM replacement?
> Hmm, I don't know; I just assumed it would be good to fix. It's this one:
"VirtualBox Graphics Adapter"
If we care to avoid the crash, it would perhaps be best to just skip
(using something along the lines of is_warp()) all the tests at the
start. VirtualBox results aren't going to be meaningful.
More information about the wine-devel