[PATCH 3/4] dx8vb: Add Direct3D8 interface with stubs

Fabian Maurer dark.shadow4 at web.de
Mon Oct 30 20:31:14 CDT 2017


> > 
> > -    FIXME("(%p): stub!\n", ret);
> > +    HRESULT res = direct3d8_create(ret);
> > 
> > -    return E_NOTIMPL;
> > +    TRACE("(%p) -> (%x)\n", ret, res);
> > +
> > +    return res;
> > 
> >  }
> 
> That's an unusual way to arrange things. Why don't you return as "return
> direct3d8_create();" ?

I did this so I can trace the return value. Since it's a wrapper with nearly 
no own code I figured it makes sense. Is this unneeded? Because if so, I'll 
change that.

Regards,
Fabian Maurer



More information about the wine-devel mailing list