[PATCH 1/4] dx8vb: Add stubs for D3DX8 interface
Fabian Maurer
dark.shadow4 at web.de
Mon Oct 30 20:35:06 CDT 2017
> > +
> > +/*** d3dx8 - IUnknown methods ***/
> > +
>
> Comment seems a bit useless, you're not going to use this file for anything
> else.
What makes you think that? There are more interfaces that could be
implemented.
> > + if (IsEqualGUID(riid, &IID_IUnknown))
> > + *ppv = &This->ID3DX8_iface;
> > + else if(IsEqualGUID(riid, &IID_ID3DX8))
> > + *ppv = &This->ID3DX8_iface;
> > + else if(IsEqualGUID(riid, &IID_IPersistPropertyBag))
> > + FIXME("No interface for IID_IPersistPropertyBag\n");
> > + else if(IsEqualGUID(riid, &IID_IPersistStreamInit))
> > + FIXME("No interface for IID_IPersistStreamInit\n");
> > + else
>
> Where does this come from?
The else part with
> FIXME("No interface for %s\n", debugstr_guid(riid));
outputted this GUID, so I added a specific FIXME for that interface. It seemed
reasonable to output a name instead of a GUID.
Regards,
Fabian Maurer
More information about the wine-devel
mailing list