[PATCH 1/4] dx8vb: Add stubs for D3DX8 interface

Matteo Bruni matteo.mystral at gmail.com
Tue Oct 31 20:31:06 CDT 2017

2017-10-31 22:30 GMT+01:00 Fabian Maurer <dark.shadow4 at web.de>:
>> (It certainly isn't helpful that
>> https://wiki.winehq.org/Wine_Developer%27s_Guide/COM_in_Wine#Implementing_a_
>> COM_interface. contains loads of old suggestions)
>> >>> +static HRESULT WINAPI d3dx8_QueryInterface(ID3DX8 *iface, REFIID riid,
>> >>> void **ppv) +{
>> >>> +    d3dx8 *This = impl_from_ID3DX8(iface);
>> >>
>> >> Please use lowercase variable names.
>> >
>> > Again, it's like this in 95% of all other cases. I'll change it if you
>> > want, I just wanted it to remain consistent with the existing code.
>> Similarly I can only refer to ddraw/d3d8/9/10/11 here, but other places
>> in Wine certainly differ.
> No problem, I'll change that. It's not a problem to use words that are
> reserved words in C++ since we're using only plain C, right?

It's not a problem but in d3d-related code we tend to avoid using
"this" as the name for object variables (e.g. you would name it
"d3dx8" here, or something like that).

In general, please give a look at recent wined3d code / commits to
have an idea WRT the code style we prefer to use in d3d.

More information about the wine-devel mailing list