[PATCH] wined3d: wined3d_check_surface_capability return TRUE for surfaces with WINED3DFMT_FLAG_TEXTURE.
Lorenzo Ferrillo
lorenzofersteam at live.it
Tue Sep 5 11:31:28 CDT 2017
In data martedì 5 settembre 2017 17:55:54 CEST, hai scritto:
> On 4 September 2017 at 18:26, lorenzo Skotos <lorenzofersteam at live.it>
wrote:
> > - if (format->glInternal)
> > + if (format->glInternal || format->flags[WINED3D_GL_RES_TYPE_TEX_2D] &
> > WINED3DFMT_FLAG_TEXTURE)
> That should fix the regression, but since the ambiguity of
> WINED3DFMT_FLAG_TEXTURE led to the issue in the first place, I'd
> rather not simply restore the check. Instead, I think it would be
> better to explicitly mark these special "extension" formats as such.
> In theory Matteo has a patch for that.
Which issue was caused by relying on WINED3DFMT_FLAG_TEXTURE ?
I admit that I know nothing about directx or wined3d (and the code is not
much documented. ). Also considering that this specific control wasn't the
only thing that was removed in that commit.
I'd certianly like to learn a better way to deal with these issues. My
studying of the wine source code started recently.
Thanks.
P.S Sorry I wrongly sent the response on your email instead of the mailing
list
More information about the wine-devel
mailing list