[v5 PATCH] wmvcore/tests: add tests for WMReader methods

Jefferson Carpenter jeffersoncarpenter2 at gmail.com
Wed Sep 6 15:29:16 CDT 2017


Okay, that makes sense.  For the implementation, should libav be used, or
ought wine to have its own implementation of the codecs?

On Tue, Sep 5, 2017 at 1:43 PM, Alexandre Julliard <julliard at winehq.org>
wrote:

> Jefferson Carpenter <jeffersoncarpenter2 at gmail.com> writes:
>
> > Without a large binary file, how would we test the successful
> > processing of an audio or video file? We could use an IWMWriter to
> > create it, but then we wouldn't be testing for conformance against the
> > Windows API.
>
> In general, to test something like a file loader, you'd want to test
> multiple files with various contents, including invalid values for
> header fields and the like. This is better done by generating them
> instead of including pre-built binaries. Like you said, using IWMWriter
> wouldn't guarantee that we are testing the right thing, so we'd most
> likely want to generate them by hand somehow.
>
> Again, this would be better done along with the implementation, so we
> can get a better idea of what cases would be interesting to test.
>
> --
> Alexandre Julliard
> julliard at winehq.org
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20170906/fbd280f7/attachment.html>


More information about the wine-devel mailing list