[PATCH 1/3] mshtml: Add a null parameter check in do_query_service().
Zebediah Figura
zfigura at codeweavers.com
Thu Sep 14 13:48:26 CDT 2017
On 09/14/2017 01:45 PM, Jacek Caban wrote:
> Hi Zebediah,
>
> On 14.09.2017 20:42, Zebediah Figura wrote:
>> diff --git a/dlls/mshtml/main.c b/dlls/mshtml/main.c
>> index af716d1680..43270b9cc8 100644
>> --- a/dlls/mshtml/main.c
>> +++ b/dlls/mshtml/main.c
>> @@ -190,6 +190,9 @@ HRESULT do_query_service(IUnknown *unk, REFGUID guid_service, REFIID riid, void
>> IServiceProvider *sp;
>> HRESULT hres;
>>
>> + if (!unk)
>> + return E_FAIL;
>
>
> I think it would be cleaner to add NULL check to caller.
>
>
> Thanks,
>
> Jacek
>
Alright, I'll change this. Any other comments on the series before I resend?
More information about the wine-devel
mailing list