vbscript: Improve parsing of separators in loops and switches.
Jacek Caban
jacek at codeweavers.com
Fri Sep 22 08:31:00 CDT 2017
Hi Dmitry,
Thanks for the patch, it generally looks good. I have a few comments bellow.
On 20.09.2017 05:48, Dmitry Kislyuk wrote:
>
> +StSeps
> + : StSep
> + | StSep StSeps
Since you're changing all uses of StSep, I think it would make more
sense to change StSep itself to accept multiple separator.
> x = 0
> -Do While x < 2 : x = x + 1
> +Do While x < 2 :
> +x = x + 1
> Loop
> Call ok(x = 2, "x not equal to 2")
Please don't change existing tests like that. We want previous version
tested as well. Add new ones instead.
> @@ -511,7 +533,8 @@ Call collectionObj.reset()
> y = 0
> x = 10
> z = 0
> -for each x in collectionObj : z = z + 2
> +for each x in collectionObj :
> + :z = z + 2
Same here.
Thanks,
Jacek
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20170922/9578c34d/attachment-0001.html>
More information about the wine-devel
mailing list