[PATCH] dmime: Call interface methods properly.

Michael Stefaniuc mstefani at winehq.org
Sun Apr 1 08:44:01 CDT 2018


wine$ git am /tmp/\[PATCH\]\ dmime\:\ Call\ interface\ methods\
properly..eml
Applying: dmime: Call interface methods properly.
*
* You have some suspicious patch lines:
*
* In dlls/dmime/audiopath.c
* mixed SPACE and TAB indent (line 154)
dlls/dmime/audiopath.c:154:	    IDirectSoundBuffer_QueryInterface
(This->pPrimary, &IID_IDirectSound3DListener, ppObject);


When you resubmit please remove also the space between function name and
opening bracket.

bye
	michael


On 03/30/2018 06:04 AM, Zebediah Figura wrote:
> Signed-off-by: Zebediah Figura <z.figura12 at gmail.com>
> ---
>  dlls/dmime/audiopath.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/dlls/dmime/audiopath.c b/dlls/dmime/audiopath.c
> index d656058..1aad13b 100644
> --- a/dlls/dmime/audiopath.c
> +++ b/dlls/dmime/audiopath.c
> @@ -114,7 +114,7 @@ static ULONG WINAPI IDirectMusicAudioPathImpl_Release (IDirectMusicAudioPath *if
>  
>      if (ref == 0) {
>          if (This->pDSBuffer)
> -            IDirectSoundBuffer8_Release(This->pDSBuffer);
> +            IDirectSoundBuffer_Release(This->pDSBuffer);
>          This->pPerf = NULL;
>          HeapFree(GetProcessHeap(), 0, This);
>      }
> @@ -140,7 +140,7 @@ static HRESULT WINAPI IDirectMusicAudioPathImpl_GetObjectInPath (IDirectMusicAud
>                    IsEqualIID (iidInterface, &IID_IDirectSoundBuffer)  ||
>                    IsEqualIID (iidInterface, &IID_IDirectSoundBuffer8) ||
>                    IsEqualIID (iidInterface, &IID_IDirectSound3DBuffer)) {
> -                  return IDirectSoundBuffer8_QueryInterface (This->pDSBuffer, iidInterface, ppObject);
> +                  return IDirectSoundBuffer_QueryInterface (This->pDSBuffer, iidInterface, ppObject);
>                }
>  
>                WARN("Unsupported interface %s\n", debugstr_dmguid(iidInterface));
> @@ -151,7 +151,7 @@ static HRESULT WINAPI IDirectMusicAudioPathImpl_GetObjectInPath (IDirectMusicAud
>  
>  	case DMUS_PATH_PRIMARY_BUFFER: {
>  	  if (IsEqualIID (iidInterface, &IID_IDirectSound3DListener)) {
> -	    IDirectSoundBuffer8_QueryInterface (This->pPrimary, &IID_IDirectSound3DListener, ppObject);
> +	    IDirectSoundBuffer_QueryInterface (This->pPrimary, &IID_IDirectSound3DListener, ppObject);
>  	    return S_OK;
>  	  } else {
>  	    FIXME("bad iid...\n");
> 




More information about the wine-devel mailing list