[PATCH 1/3] msctf:return S_OK in TextStoreACPSink_OnTextChange

Aric Stewart aric at codeweavers.com
Wed Apr 4 07:22:05 CDT 2018


Signed-off-by: Aric Stewart <aric at codeweavers.com>

On 4/4/18 4:47 AM, Louis Lenders wrote:
> 
> This is for bug 44404
> 
> Several .Net applications crash on these stubs returning E_NOTIMPL.
>   Returning S_OK makes the crashes gone, up to now i`ve not seen this causes any unwanted side-effects/ no new crashes as far as I can tell.
> Example of program that crashes quite quickly is installer of https://www.remembear.com/download/
> 
> 
> 
> Signed-off-by: Louis Lenders <xerox.xerox2000x at gmail.com>
> ---
>   dlls/msctf/context.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/dlls/msctf/context.c b/dlls/msctf/context.c
> index 54052f6..70b06e2 100644
> --- a/dlls/msctf/context.c
> +++ b/dlls/msctf/context.c
> @@ -758,7 +758,7 @@ static HRESULT WINAPI TextStoreACPSink_OnTextChange(ITextStoreACPSink *iface,
>   {
>       Context *This = impl_from_ITextStoreACPSink(iface);
>       FIXME("STUB:(%p)\n",This);
> -    return E_NOTIMPL;
> +    return S_OK;
>   }
>   
>   static HRESULT WINAPI TextStoreACPSink_OnSelectionChange(ITextStoreACPSink *iface)
> 



More information about the wine-devel mailing list