[PATCH v5 3/3] kernel32: Implement NormalizeString API function.

Sergio Gómez Del Real sdelreal at codeweavers.com
Fri Apr 6 08:16:06 CDT 2018


On 06/04/18 03:25, Huw Davies wrote:

> On 4 Apr 2018, at 18:12, Sergio Gómez Del Real <sdelreal at codeweavers.com> wrote:
>> diff --git a/dlls/kernel32/tests/locale.c b/dlls/kernel32/tests/locale.c
>> index a99763db92..8cc3b62730 100644
>> --- a/dlls/kernel32/tests/locale.c
>> +++ b/dlls/kernel32/tests/locale.c
>> @@ -36,6 +36,8 @@
>> #include "winerror.h"
>> #include "winnls.h"
>>
>> +#include “normalization_tests.h"
> What’s the reason for hiding the data away in a header file?
> Are you planning on sharing it with other source files?
>
> Huw.
>

No technical reason. I just thought it wouldn't look very nice to see 
all that 'noise' in the code (specially since I would like to add more 
tests in the future, maybe some of them even more convoluted). Do you 
think this is a good enough reason to move out the test data into its 
own file?



More information about the wine-devel mailing list