[PATCH v5 3/3] kernel32: Implement NormalizeString API function.

Huw Davies huw at codeweavers.com
Fri Apr 6 08:19:31 CDT 2018


On 6 Apr 2018, at 14:16, Sergio Gómez Del Real <sdelreal at codeweavers.com> wrote:
> On 06/04/18 03:25, Huw Davies wrote:
>> What’s the reason for hiding the data away in a header file?
>> Are you planning on sharing it with other source files?
> No technical reason. I just thought it wouldn't look very nice to see all that 'noise' in the code (specially since I would like to add more tests in the future, maybe some of them even more convoluted). Do you think this is a good enough reason to move out the test data into its own file?

No.  You’re going to want to look at that ‘noise’ to see what
the tests are doing, so hiding them away just makes life more
difficult.

Huw.




More information about the wine-devel mailing list