[PATCH 1/2] tools/make_unicode: Implement full Unicode character decomposition.
Huw Davies
huw at codeweavers.com
Wed Apr 11 03:13:57 CDT 2018
On Tue, Apr 10, 2018 at 04:25:54PM -0500, Sergio Gómez Del Real wrote:
> Signed-off-by: Sergio Gómez Del Real <sdelreal at codeweavers.com>
> ---
> libs/port/mbtowc.c | 14 +-
> tools/make_unicode | 423 +++++++++++++++++++++++++++++++++++++++++++++--------
> 2 files changed, 370 insertions(+), 67 deletions(-)
What this patch is doing is to add a 'compat' flag to wine_decompose()
and then always call that function with that flag set. So essentially
you've added a bunch of dead code (the compat not set case).
The patch needs to make some material difference to the Wine's
implementation of the Win32 api, preferably demonstrated by a test; it
currently does not do that.
Similar comments could be made about patch [2/2].
Huw.
More information about the wine-devel
mailing list