[PATCH 1/6] msi: Make MsiGetProperty() RPC-compatible.

Dmitry Timoshkov dmitry at baikal.ru
Mon Apr 16 21:20:21 CDT 2018


Zebediah Figura <z.figura12 at gmail.com> wrote:

> +    r = MsiGetPropertyW(hinst, property, empty, &size);
> +    if (r == ERROR_MORE_DATA)
> +    {
> +        *value = midl_user_allocate(++size * sizeof(WCHAR));

While this construct works as expected could you please avoid this kind
of convoluted thing to make it look less tricky?

> +        if (!*value)
> +            return ERROR_OUTOFMEMORY;
> +        r = MsiGetPropertyW(hinst, property, *value, &size);
> +    }
> +    return r;
>  }

-- 
Dmitry.



More information about the wine-devel mailing list