[v4 PATCH] shell32: Implement SHCreateSessionKey.

[Dmitry Timoshkov]

Alistair Leslie-Hughes <leslie_alistair at hotmail.com> wrote:

> +    static const WCHAR session_format[] = {
> +                'S','o','f','t','w','a','r','e','\\','M','i','c','r','o','s','o','f','t','\\',
> +                'W','i','n','d','o','w','s','\\','C','u','r','r','e','n','t','V','e','r','s','i','o','n','\\',
> +                'E','x','p','l','o','r','e','r','\\','S','e','s','s','i','o','n','I','n','f','o','\\','%','d',0};
> +    DWORD session;

Still not fixed.

> +    static const WCHAR session_format[] = {
> +                'S','o','f','t','w','a','r','e','\\','M','i','c','r','o','s','o','f','t','\\',
> +                'W','i','n','d','o','w','s','\\','C','u','r','r','e','n','t','V','e','r','s','i','o','n','\\',
> +                'E','x','p','l','o','r','e','r','\\','S','e','s','s','i','o','n','I','n','f','o','\\','%','d',0};
>      HKEY hkey, hkey2;
>      HRESULT hr;
> +    DWORD session;

Same here.

> +    trace("key: %016x\n", session);

Why %016x ?

> +    ret = RegOpenKeyW(HKEY_CURRENT_USER, sessionW, &hkey);
> +    ok(!ret || broken(ret), "key not found\n");

Most likely this is always broken since the session key format is
Wine specific. That means that this test is useless and should be
dropped.

-- 
Dmitry.