[PATCH 3/7] wsdapi: Build and write Types list for Hello message.

Owen Rudge owen at owenrudge.net
Fri Apr 20 03:16:55 CDT 2018


Hi Huw,

> Is it possible that list could be NULL so that the while loop is never
> executed?  If so, then the above line would touch buffer[-1].  If
> list is never NULL consider rewriting the loop as a do-while.

No, the list is checked for NULL in the calling function. I can rewrite it as a do-while though for clarity.

Thanks,

Owen



More information about the wine-devel mailing list