[PATCH] Revert "testbot/web: Tweak ItemPage to save the Item directly."

Francois Gouget fgouget at codeweavers.com
Sat Apr 21 12:56:52 CDT 2018


Saving the item directly is ok when modifying it, but DBIBackend only
supports saving new items through the collection. In particular the
registration web page depends on that so we have no choice but to go
through the collection.

This reverts commit c18379abe004411ca779d4c42e26d7e7f3d72ba6.
---
 testbot/lib/ObjectModel/CGI/ItemPage.pm | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/testbot/lib/ObjectModel/CGI/ItemPage.pm b/testbot/lib/ObjectModel/CGI/ItemPage.pm
index c208aea31..9b9f2ff7e 100644
--- a/testbot/lib/ObjectModel/CGI/ItemPage.pm
+++ b/testbot/lib/ObjectModel/CGI/ItemPage.pm
@@ -134,16 +134,6 @@ sub SaveProperty($$$)
   return 1;
 }
 
-sub Save($)
-{
-  my ($self) = @_;
-
-  return !1 if (!$self->SaveProperties());
-
-  ($self->{ErrField}, $self->{ErrMessage}) = $self->{Item}->Save();
-  return ! defined($self->{ErrMessage});
-}
-
 sub OnAction($$)
 {
   my ($self, $Action) = @_;
-- 
2.17.0



More information about the wine-devel mailing list