[PATCH 4/5] wined3d: Avoid using gl_ViewportIndex unnecessarily.

Józef Kucia joseph.kucia at gmail.com
Mon Apr 23 16:50:13 CDT 2018


On Mon, Apr 23, 2018 at 10:49 PM, Henri Verbeet <hverbeet at gmail.com> wrote:
> On 23 April 2018 at 18:50, Józef Kucia <jkucia at codeweavers.com> wrote:
>> Fixes geometry shaders when ARB_viewport_array is not available.
>>
> While the patch seems fine, should that situation ever happen? I.e.,
> shouldn't SM4 simply require ARB_viewport_array?

Yes, it might be right thing to require ARB_viewport_array. On the
other hand, it might be quite inconvenient for Wine users because it
might disable SM4 on some systems. e.g. on macOS with OpenGL 3.3
(ARB_viewport_array is core since OpenGL 4.1). If we really want to do
this we probably should add a way to force a higher shader model than
supported by extensions reported by an OpenGL implementation.



More information about the wine-devel mailing list