[PATCH resend] user32/tests: Fix broadcast test failures on Windows 10

Alexandre Julliard julliard at winehq.org
Fri Apr 27 12:37:57 CDT 2018


Alex Henrie <alexhenrie24 at gmail.com> writes:

> On Thu, Apr 26, 2018 at 3:39 PM Marvin <testbot at winehq.org> wrote:
>
>> Thank you for your contribution to Wine!
>
>> This is an automated notification to let you know that your patch has
>> been reviewed and its status set to "Rejected".
>
>> This means that the patch has been rejected by a reviewer. You should
>> have received a mail explaining why it was rejected. You need to fix
>> the issue and resend the patch, or if you are convinced that your
>> patch is good as is, you should reply to the rejection message with
>> your counterarguments.
>
>> If you do not understand the reason for this status, disagree with our
>> assessment, or are simply not sure how to proceed next, please ask for
>> clarification by replying to this email.
>
> What is the right way to fix these test failures? Do you think the
> pre-win10 behavior should be marked as broken?

I'm not sure this privilege dropping is meaningful at all. I feel it
would be more useful to test more behaviors of that function under
normal privileges, with hopefully consistent results across platforms.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list