[PATCH 1/2] quartz: Remove redundant if clause from WAVEParser_InputPin_PreConnect

Andrew Eikum aeikum at codeweavers.com
Fri Aug 10 07:57:58 CDT 2018


Signed-off-by: Andrew Eikum <aeikum at codeweavers.com>

On Fri, Aug 10, 2018 at 12:00:33AM -0600, Alex Henrie wrote:
> Signed-off-by: Alex Henrie <alexhenrie24 at gmail.com>
> ---
>  dlls/quartz/waveparser.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/dlls/quartz/waveparser.c b/dlls/quartz/waveparser.c
> index 403c052db4..d8f349b35f 100644
> --- a/dlls/quartz/waveparser.c
> +++ b/dlls/quartz/waveparser.c
> @@ -306,15 +306,12 @@ static HRESULT WAVEParser_InputPin_PreConnect(IPin * iface, IPin * pConnectPin,
>          return E_FAIL;
>      }
>  
> -    if (hr == S_OK)
> -    {
> -        pWAVEParser->StartOfFile = MEDIATIME_FROM_BYTES(pos + sizeof(RIFFCHUNK));
> -        pWAVEParser->EndOfFile = MEDIATIME_FROM_BYTES(pos + chunk.cb + sizeof(RIFFCHUNK));
> -    }
> -
>      if (hr != S_OK)
>          return E_FAIL;
>  
> +    pWAVEParser->StartOfFile = MEDIATIME_FROM_BYTES(pos + sizeof(RIFFCHUNK));
> +    pWAVEParser->EndOfFile = MEDIATIME_FROM_BYTES(pos + chunk.cb + sizeof(RIFFCHUNK));
> +
>      props->cbAlign = ((WAVEFORMATEX*)amt.pbFormat)->nBlockAlign;
>      props->cbPrefix = 0;
>      props->cbBuffer = 4096;
> -- 
> 2.18.0
> 



More information about the wine-devel mailing list