[PATCH] kernel32: Add AttachConsole implementation.

Francois Gouget fgouget at codeweavers.com
Fri Aug 10 11:35:42 CDT 2018


On Thu, 9 Aug 2018, Jacek Caban wrote:
[...]
> It looks like Testbot can't handle patches requiring make_request.

Yep. The TestBot does not know about make_request. My understanding is 
that make_request should be rerun whenever server/protocol.def is 
modified. Is that all?

The question is whether this dependency should be handled by the 
makefiles. If the answer is yes then the generated files should be 
removed from Git otherwise there will be timestamp problems, and I would 
let Alexandre tweak the makefiles.

If not and all that's required is detecting patches to 
server/protocol.def, then it's quite easy to add support for it to the 
TestBot.


-- 
Francois Gouget <fgouget at codeweavers.com>



More information about the wine-devel mailing list