[PATCH vkd3d v3 2/7] build: Make the sed(1) command more portable.

[Chip Davis]

August 10, 2018 3:10 PM, "Chip Davis" <cdavis at codeweavers.com> wrote:

> August 10, 2018 3:05 PM, "Henri Verbeet" <hverbeet at gmail.com> wrote:
> 
>> On 8 August 2018 at 02:02, Chip Davis <cdavis at codeweavers.com> wrote:
>> 
>>> diff --git a/Makefile.am b/Makefile.am
>>> index 14f2d51..7299192 100644
>>> --- a/Makefile.am
>>> +++ b/Makefile.am
>>> @@ -150,8 +150,9 @@ vkd3d_v_widl_1 =
>>> EXTRA_DIST += $(widl_headers) $(widl_headers:.h=.idl)
>>> $(widl_headers): %.h: %.idl
>>> if HAVE_WIDL
>>> - $(VKD3D_V_WIDL)$(WIDL) -o $@ $<
>>> - sed -e '/#include <\(rpc.h\|rpcndr.h\)>/d' -i $@
>>> + $(VKD3D_V_WIDL)$(WIDL) -o $@.tmp $<
>> 
>> Actually, did you test these patches? This doesn't work unless you
>> also pass -h to widl.
> 
> It was like that when I found it. (As you can see from the diff.) It seems to work for me.

From the manpage:

-o, --output=name
        Set the name of the output file. When generating multiple output
        files, this sets only the base name of the file; the respective
        output files are then named name.h, name_p.c, etc. *If a full
        file name with extension is specified, only that file is gener-
        ated.* [emphasis added]

Chip