[PATCH 4/6] sxs: Add tests for SxsLookupClrGuid

Nikolay Sivov nsivov at codeweavers.com
Sat Aug 11 11:28:52 CDT 2018


On 8/7/2018 10:14 PM, Fabian Maurer wrote:
>
> > Please use usual naming conventions for function pointer, and argument
>
> > types.
>
>  
>
> Shouldn't I keep it the function the same as it's defined?
>
Is it defined anywhere in SDK?

>  
>
>  
>
> > Pointer type is not used.
>
>  
>
> Yeah, I kept the declaration the same as usual, but I can remove the
> pointer type.
>
>  
>
> > What's a point of pointer test, is it missing on some Windows versions?
>
>  
>
> It's missing on wine, currently. How do you want me to handle that?
>
Add a stub, or merge patches.

>  
>
> Regards,
>
> Fabian Maurer
>




More information about the wine-devel mailing list